Hi Geert, On 11/15/19 2:01 PM, Geert Uytterhoeven wrote: > Hi Jacek, > > On Sun, Jun 9, 2019 at 9:09 PM Jacek Anaszewski > <jacek.anaszewski@xxxxxxxxx> wrote: >> Add initial set of common LED function definitions. >> >> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> > >> --- a/include/dt-bindings/leds/common.h >> +++ b/include/dt-bindings/leds/common.h >> @@ -30,4 +31,45 @@ >> #define LED_COLOR_ID_IR 7 >> #define LED_COLOR_ID_MAX 8 >> >> +/* Standard LED functions */ >> +#define LED_FUNCTION_ACTIVITY "activity" > > What's the appropriate function for "general purpose" or "user" LEDs on > development boards, where the LEDs don't have fixed functions, unlike > on real products? > Perhaps just LED_FUNCTION_INDICATOR? LED_FUNCTION_INDICATOR was introduced to address current occurrences of indicator LEDs that are customary for LED flash controllers. Such LEDs usually indicate that camera sensor is capturing images. In the v5 of the patch set [0] I proposed also a documentation for LED functions but there was little interest in it and no broader discussion took place, so I didn't apply it. It would be good to include that finally to avoid abusing the LED names for irrelevant use cases. > I noticed your very initial submission defined LED_FUNCTION_USER "user". > I couldn't find an explanation for the rationale behind its removal in later > revisions, or any discussion asking for that. I was asked at some point to give rationale for standardizing particular LED names and couldn't have come up with anything convincing for "user". This is however an initial set of standard LED names, so we can always add new ones. If you like please submit a patch adding what you deem is missing. [0] https://lore.kernel.org/linux-leds/20190609190803.14815-27-jacek.anaszewski@xxxxxxxxx/ -- Best regards, Jacek Anaszewski
