Hi! > The NETDEV_CHANGENAME code is not "unneeded" like it is stated in commit > 4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface > rename"). > > The event was accidentally misinterpreted equivalent to > NETDEV_UNREGISTER, but should be equivalent to NETDEV_REGISTER. > > This was the case in the original code from the openwrt project. > > Otherwise, you are unable to set netdev led triggers for (non-existent) > netdevices, which has to be renamed. This is the case, for example, for > ppp interfaces in openwrt. > > Fixes: 06f502f57d0d ("leds: trigger: Introduce a NETDEV trigger") > Fixes: 4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface rename") > Signed-off-by: Martin Schiller <ms@xxxxxxxxxx> Thanks, applied. I assume it does not fix _real bad_ bug to qualify for stable. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature