Hello Linus, On Sun, 2019-11-03 at 23:30 +0100, Linus Walleij wrote: > Hi Matti! > > Good initiative (and I will see a ton of janitorial patches as a > result of this...) Yep. I think I might pull this change out of the RFC and send it separately. I can also do some conversions for existing drivers - but I won't probably be able to do all of the drivers. I see no way of doing any search and replace scripting here - this conversion is going to be manual work :/ > > On Fri, Nov 1, 2019 at 12:50 PM Matti Vaittinen > <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > > > At least for me it is difficult to remember the meaning of GPIO > > direction values. Define GPIO_IN and GPIO_OUT so that occasional > > GPIO contributors would not need to always check the meaning of > > hard coded values 1 and 0. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > (...) > > +#define GPIO_IN 1 > > +#define GPIO_OUT 0 > > Please spell it out or people will be confused: > > GPIO_LINE_DIRECTION_IN > GPIO_LINE_DIRECTION_OUT Right. Besides the 0Day test suite did already spot a few redefinition problems when some drivers do define GPIO_IN and/or GPIO_OUT... So I'll change the defines to what you suggest here. Br, Matti Vaittinen
