Hi Matti, Thanks for your patch! On Thu, Oct 24, 2019 at 1:51 PM Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > ROHM BD71828 PMIC contains 4 pins which can be configured by OTP > to be used for general purposes. First 3 can be used as outputs > and 4.th pin can be used as input. Allow them to be controlled > via GPIO framework. > > The driver assumes all of the pins are configured as GPIOs and > trusts that the reserved pins in other OTP configurations are > excluded from control using "gpio-reserved-ranges" device tree > property (or left untouched by GPIO users). > > Typical use for 4.th pin (input) is to use it as HALL sensor > input so that this pin state is toggled when HALL sensor detects > LID position change (from close to open or open to close). PMIC > HW implements some extra logic which allows PMIC to power-up the > system when this pin is toggled. Please see the data sheet for > details of GPIO options which can be selcted by OTP settings. spelling of selected > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> Overall looks very good. > +// SPDX-License-Identifier: GPL-2.0 I think they want you to use GPL-2.0-only these days. > +#define BD71828_OUT 0 > +#define BD71828_IN 1 These have nothing to do with BD71828, just skip these defines and hardcode 0/1 in the code called from gpiolib. If we want defines for this they should be generically named and put in <linux/gpio/driver.h> Nice use of the config API! Yours, Linus Walleij
