Hi Krzysztof, Thank you for the patch set. On 8/30/19 8:11 PM, Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations ramp_table, > als_avrg_table and als_imp_table, and resolve the following > compiler warnings that can be seen when building with warnings > enabled (W=1): > > drivers/leds/leds-lm3532.c:209:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/leds/leds-lm3532.c:266:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/leds/leds-lm3532.c:281:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski <kw@xxxxxxxxx> > --- > Related: https://lore.kernel.org/r/20190827233017.GK9987@xxxxxxxxxx > > drivers/leds/leds-lm3532.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c > index c5cfd8e3f15f..62ace6698d25 100644 > --- a/drivers/leds/leds-lm3532.c > +++ b/drivers/leds/leds-lm3532.c > @@ -208,7 +208,7 @@ static const struct regmap_config lm3532_regmap_config = { > .cache_type = REGCACHE_FLAT, > }; > > -const static int als_imp_table[LM3532_NUM_IMP_VALS] = {37000, 18500, 12330, > +static const int als_imp_table[LM3532_NUM_IMP_VALS] = {37000, 18500, 12330, > 92500, 7400, 6170, 5290, > 4630, 4110, 3700, 3360, > 3080, 2850, 2640, 2440, > @@ -265,7 +265,7 @@ static int lm3532_get_index(const int table[], int size, int value) > return -EINVAL; > } > > -const static int als_avrg_table[LM3532_NUM_AVG_VALS] = {17920, 35840, 71680, > +static const int als_avrg_table[LM3532_NUM_AVG_VALS] = {17920, 35840, 71680, > 1433360, 286720, 573440, > 1146880, 2293760}; > static int lm3532_get_als_avg_index(int avg_time) > @@ -280,7 +280,7 @@ static int lm3532_get_als_avg_index(int avg_time) > avg_time); > } > > -const static int ramp_table[LM3532_NUM_RAMP_VALS] = { 8, 1024, 2048, 4096, 8192, > +static const int ramp_table[LM3532_NUM_RAMP_VALS] = { 8, 1024, 2048, 4096, 8192, > 16384, 32768, 65536}; > static int lm3532_get_ramp_index(int ramp_time) > { > Both 1/2 and 2/2 applied. -- Best regards, Jacek Anaszewski
