Pavel
Thanks for the review
On 8/19/19 5:55 AM, Pavel Machek wrote:
Hi!
Allow the full scale current to be configured at init.
Valid rangles are 5mA->29.8mA.
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
@@ -121,6 +125,7 @@ struct lm3532_als_data {
* @mode - Mode of the LED string
* @ctrl_brt_pointer - Zone target register that controls the sink
* @num_leds - Number of LED strings are supported in this array
+ * @full_scale_current - The full-scale current setting for the current sink.
* @led_strings - The LED strings supported in this array
* @label - LED label
*/
@@ -130,8 +135,9 @@ struct lm3532_led {
int control_bank;
int mode;
- int ctrl_brt_pointer;
int num_leds;
+ int ctrl_brt_pointer;
+ int full_scale_current;
u32 led_strings[LM3532_MAX_CONTROL_BANKS];
char label[LED_MAX_NAME_SIZE];
};
No need to move ctrl_brt_pointer... to keep order consistent with docs.
OK I will reset the patches and get rid of that change. I think this
got moved when I applied the v1 patch.
+ fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
+ LM3532_FS_CURR_STEP;
The computation is wrong ... needs () AFAICT.
Hmm. Doesn't order of operations take precedence?
I will add the () unless checkpatch cribs about them
Dan
Best regards,
Pavel
