Hi Oleh, On 6/12/19 12:58 PM, Oleh Kravchenko wrote:
Dan, Jacek and Pavel, Let me also describe blinking effect for Screen Frame LED tube, because looks like blink_set() doesn't support smooth blinking.brightness ^ | *** *** ** > ** ** ** ** ** | * * * * * > * * * * * | ** ** ** ** ** >** *** *** | +----^----^----^----^----^----^----^----^----^----> timeSo it's actually never go to OFF state, when effect is set. It is always in ON state, just brightness is smoothly changed from min to max. It all handled by LEDs board itself, there are no way to control it from SPI master. Please advice how it can be implemented to pass review?
In this case you need to leverage pattern trigger and implement pattern_set op that will enable this hardware effect when certain vales are given. You need to document those values in ABI documentation file. Please compare Documentation/ABI/testing/sysfs-class-led-driver-sc27xx. -- Best regards, Jacek Anaszewski
