Re: [PATCH v2 1/2] dt-bindings: Add docs for EL15203000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/9/19 10:23 PM, Oleh Kravchenko wrote:


09.06.19 22:31, Jacek Anaszewski пише:
Oleh,

On 6/9/19 8:13 PM, Oleh Kravchenko wrote:
Jacek,

09.06.19 15:24, Jacek Anaszewski пише:
Hi Oleh,

On 6/8/19 12:42 AM, Oleh Kravchenko wrote:

You want to set timer trigger (first turn it on in the config):

echo "timer" > trigger

After that two files appear: delay_on and delay_off.

ledtrig-timer uses blink_set op for setting up the hw blinking.

Thank you for explanation.

I just want to clerify - for now LEDs board has 2 from 3 LEDs with effect function.

1. Screen frame led is just blinking, so blink_set() is fit well to this.
2. Pipe led actually consist from 3 leds and when effect is enabled next pattern is used:

        ^
        |
LED1  >   OFF  ON   ON   ON
        |
LED2  >   OFF  OFF  ON   ON
        |
LED3  >   OFF  OFF  OFF  ON
        |
        +----^----^----^----^----> time

Pattern trigger applies to a single LED so it won't fit for this
pattern.

Currently we don't support patterns spanning on multiple LEDs,
so you would have to come up with your own solution.

What I can recommend is a trigger that would be created by your driver
and would activate this sequence.


How to be sure this trigger can be applied only to Pipe LED?

After thinking a bit more of it I came to the conclusion that instead
of a trigger the driver should create its own specific sysfs files for controlling the effect.

Some time ago we had a proposal of generic support for hardware triggers
that this one could make use of, but the idea didn't seem to introduce
much gain in comparison to the driver specific files.

So, you could have "effect_on" file which would accept "true" or "false"
(other API name proposals are welcome), that would be created by
every LED class device created by the driver.

The effect will be activated when all three LEDs have the effect_on
file value set to "true".

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux