Re: [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Machek <pavel@xxxxxx>
Subject: Re: [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Sun, 13 May 2018 17:34:42 +0300
Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>, "open list:SERIAL DRIVERS" <linux-serial@xxxxxxxxxxxxxxx>, Linux LED Subsystem <linux-leds@xxxxxxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, Sascha Hauer <kernel@xxxxxxxxxxxxxx>, One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, linux-arm Mailing List <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20180510112229.GE6977@amd>
References: <20180508100543.12559-1-u.kleine-koenig@pengutronix.de> <20180508100543.12559-2-u.kleine-koenig@pengutronix.de> <20180510112101.GD6977@amd> <20180510112229.GE6977@amd>

On Thu, May 10, 2018 at 2:22 PM, Pavel Machek <pavel@xxxxxx> wrote:
> On Thu 2018-05-10 13:21:01, Pavel Machek wrote:

>> I know this is not your fault, but if you have a space or "[]" in
>> netdev names, confusing things will happen.
>
> Hmm. If we are doing this we really should check trigger names for
> forbidden characters. At least "[] " should be forbidden.

So, string_escape_mem() is your helper here.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v3 0/3] led_trigger_register_format and tty triggers
  - From: Uwe Kleine-König
- [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()
  - From: Uwe Kleine-König
- Re: [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()
  - From: Pavel Machek
- Re: [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()
  - From: Pavel Machek

Prev by Date: Re: [PATCH v3 3/3] tty: implement led triggers
Next by Date: [PATCH v4 1/2] dt-bindings: leds: Add SC27xx breathing light controller documentation
Previous by thread: Re: [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format()
Next by thread: [PATCH v3 3/3] tty: implement led triggers
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]