On Tue, May 8, 2018 at 1:05 PM, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > The rx trigger fires when data is pushed to the ldisc by the driver. This > is a bit later than the actual receiving of data but has the nice benefit > that it doesn't need adaption for each driver and isn't in the hot path. > > Similarly the tx trigger fires when data was copied from userspace and is > given to the ldisc. > #include <uapi/linux/tty.h> > #include <linux/rwsem.h> > #include <linux/llist.h> > +#include <linux/leds.h> Even for unordered lists of inclusions I would still try to put new lines in "somehow" ordered positions. For example here, I would rather put it before llist.h. -- With Best Regards, Andy Shevchenko
