On 7/26/24 11:45 PM, John Hubbard wrote:
> On 7/26/24 4:06 AM, Muhammad Usama Anjum wrote:
>> Rename module to bitmap_kunit and rename the configuration option
>> compliant with kunit framework.
>>
>> Cc: kees@xxxxxxxxxx
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>> ---
>> MAINTAINERS | 2 +-
>> lib/Kconfig.debug | 15 ++++++++-------
>> lib/Makefile | 2 +-
>> lib/{test_bitmap.c => bitmap_kunit.c} | 0
>> 4 files changed, 10 insertions(+), 9 deletions(-)
>> rename lib/{test_bitmap.c => bitmap_kunit.c} (100%)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 12b870712da4a..289b727344d64 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3814,13 +3814,13 @@ F: include/linux/find.h
>> F: include/linux/nodemask.h
>> F: include/linux/nodemask_types.h
>> F: include/vdso/bits.h
>> +F: lib/bitmap_kunit.c
>> F: lib/bitmap-str.c
>> F: lib/bitmap.c
>> F: lib/cpumask.c
>> F: lib/cpumask_kunit.c
>> F: lib/find_bit.c
>> F: lib/find_bit_benchmark.c
>> -F: lib/test_bitmap.c
>
> This changes the situation from "works for Linus' tab completion
> case", to "causes a tab completion problem"! :)
>
> I think a tests/ subdir is how we eventually decided to do this [1],
> right?
Yes, Thank you for mentioning it. I'd missed the naming scheme. I'll fix it.
>
> So:
>
> lib/tests/bitmap_kunit.c
>
>
> [1] https://lore.kernel.org/20240724201354.make.730-kees@xxxxxxxxxx
>
> thanks,
--
BR,
Muhammad Usama Anjum
