On 7/26/24 05:06, Muhammad Usama Anjum wrote:
Rename module to bitmap_kunit and rename the configuration option
compliant with kunit framework.
Cc: kees@xxxxxxxxxx
Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
MAINTAINERS | 2 +-
lib/Kconfig.debug | 15 ++++++++-------
lib/Makefile | 2 +-
lib/{test_bitmap.c => bitmap_kunit.c} | 0
4 files changed, 10 insertions(+), 9 deletions(-)
rename lib/{test_bitmap.c => bitmap_kunit.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 12b870712da4a..289b727344d64 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3814,13 +3814,13 @@ F: include/linux/find.h
F: include/linux/nodemask.h
F: include/linux/nodemask_types.h
F: include/vdso/bits.h
+F: lib/bitmap_kunit.c
F: lib/bitmap-str.c
F: lib/bitmap.c
F: lib/cpumask.c
F: lib/cpumask_kunit.c
F: lib/find_bit.c
F: lib/find_bit_benchmark.c
-F: lib/test_bitmap.c
F: tools/include/linux/bitfield.h
F: tools/include/linux/bitmap.h
F: tools/include/linux/bits.h
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a30c03a661726..6bb02990a73e7 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2420,13 +2420,6 @@ config TEST_PRINTF
config TEST_SCANF
tristate "Test scanf() family of functions at runtime"
-config TEST_BITMAP
- tristate "Test bitmap_*() family of functions at runtime"
- help
- Enable this option to test the bitmap functions at boot.
-
- If unsure, say N.
-
This change will take away the ability to run bitmap tests during
boot on a non-kunit kernel.
Nack on this change. I wan to see all tests that are being removed
from lib because they have been converted - also it doesn't make
sense to convert some tests like this one that add the ability test
during boot.
thanks,
-- Shuah
