On 6/11/21 2:29 AM, Marco Elver wrote:
On Fri, 11 Jun 2021 at 05:57, David Gow <davidgow@xxxxxxxxxx> wrote:
When one parameter of a parameterised test failed, its failure would be
propagated to the overall test, but not to the suite result (unless it
was the last parameter).
This is because test_case->success was being reset to the test->success
result after each parameter was used, so a failing test's result would
be overwritten by a non-failing result. The overall test result was
handled in a third variable, test_result, but this was disacarded after
the status line was printed.
Instead, just propagate the result after each parameter run.
Signed-off-by: David Gow <davidgow@xxxxxxxxxx>
Fixes: fadb08e7c750 ("kunit: Support for Parameterized Testing")
Reviewed-by: Marco Elver <elver@xxxxxxxxxx>
Would Cc: stable be appropriate?
Thanks,
-- Marco
---
This is fixing quite a serious bug where some test suites would appear
to succeed even if some of their component tests failed. It'd be nice to
get this into kunit-fixes ASAP.
Will apply this with cc stable.
(This will require a rework of some of the skip tests work, for which
I'll send out a new version soon.)
Thanks for the heads up. I will wait for new version.
thanks,
-- Shuah
