On Thu, Jun 10, 2021 at 8:57 PM David Gow <davidgow@xxxxxxxxxx> wrote:
>
> When one parameter of a parameterised test failed, its failure would be
> propagated to the overall test, but not to the suite result (unless it
> was the last parameter).
>
> This is because test_case->success was being reset to the test->success
> result after each parameter was used, so a failing test's result would
> be overwritten by a non-failing result. The overall test result was
> handled in a third variable, test_result, but this was disacarded after
> the status line was printed.
nit: s/disacarded/discarded/g
> Instead, just propagate the result after each parameter run.
>
> Signed-off-by: David Gow <davidgow@xxxxxxxxxx>
> Fixes: fadb08e7c750 ("kunit: Support for Parameterized Testing")
I tried to reproduce the problem described and was unable to. Anyway,
from the code it definitely looks like there is a bug like you
describe. And it definitely looks like your change should fix it.
Anyway, I tried testing your fix, but given I was unable to reproduce
the failure, I am not super confident in my testing. Still,
Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
