On Fri, Oct 16, 2020 at 01:02:20PM +0800, David Gow wrote: > On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > Follow new file name convention for the KUnit tests. > > Since we have lib/*test*.c in a few variations, > > use 'kunit' suffix to distinguish usual test cases > > with KUnit-based ones. > > > > Cc: Mark Brown <broonie@xxxxxxxxxx> > > Cc: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Thanks. This looks good to me from an "I tested it and it worked" and > a "matches the naming guidelines" point of view. > > (Since the naming documentation isn't actually in Linus' branch yet, > I'll drop a link to it here: > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit > ) > > I'm not the test author though, and the naming doc does explicitly > leave the possibility of keeping the old filenames for tests if > there's a particularly good reason to (e.g., a lot depending on the > module name). Can you point out to this? Briefly looking into I haven't found that. > I'm not aware of any such thing, and so am in favour of > the rename, but will defer to the test authors on that point if they > object. > Either way, > Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Thanks! -- With Best Regards, Andy Shevchenko
