On Fri, Oct 16, 2020 at 5:29 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Oct 16, 2020 at 01:02:20PM +0800, David Gow wrote: > > On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > > Follow new file name convention for the KUnit tests. > > > Since we have lib/*test*.c in a few variations, > > > use 'kunit' suffix to distinguish usual test cases > > > with KUnit-based ones. > > > > > > Cc: Mark Brown <broonie@xxxxxxxxxx> > > > Cc: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > Thanks. This looks good to me from an "I tested it and it worked" and > > a "matches the naming guidelines" point of view. > > > > (Since the naming documentation isn't actually in Linus' branch yet, > > I'll drop a link to it here: > > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit > > ) > > > > I'm not the test author though, and the naming doc does explicitly > > leave the possibility of keeping the old filenames for tests if > > there's a particularly good reason to (e.g., a lot depending on the > > module name). > > Can you point out to this? Briefly looking into I haven't found that. This was what was intended by the first "exemption" listed[1] at the beginning of the document: "It's recommended that you only deviate from these guidelines when: [...] Porting tests to KUnit which are already known with an existing name" Admittedly, this test was originally a KUnit test, rather than a port of another test, so the exact wording probably doesn't apply here, but that's more an artefact of the naming guidelines landing after this test did. The goal here is really just to make sure that existing test modules can be ported to KUnit without breaking existing users which may depend on the name. It doesn't look like that applies for this test, though. Cheers, -- David [1]: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit#n13
