On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > Follow new file name convention for the KUnit tests. > Since we have lib/*test*.c in a few variations, > use 'kunit' suffix to distinguish usual test cases > with KUnit-based ones. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Again, this worked and looks good to me. Apart from noting that the module name will change (so if people are depending on that, it'll break things), I'm all in favour of this. For the record (since it's not quite upstream yet), the naming documentation referenced is currently available here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit Anyway, Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Thanks, -- David