The surprising thing is the Clang doesn't detect the bug either. It's strange. (I found this bug with Smatch). Also I notice that my Fixes tag wasn't correct either. That patch did have a missing error code bug, but "ret" was set to zero. :/ regards, dan carpenter