>>> There is no bug here. >> >> Do you find duplicated source code questionable? > > No. Do you disagree to the following information which can be provided by a coccicheck run? ./drivers/s390/crypto/pkey_api.c:722:8-15: WARNING opportunity for memdup_user > It is something that can be improved through > code consolidation though. > >> Is this also an error item? > > Definitely not. Your view seems to be very limited at the moment. > It is _only_ an error if there is some logic defect. > There is no logic defect here. I suggest to consider additional software weaknesses besides logic errors. Do we occasionally care any more for the development principle “Don't repeat yourself”? Regards, Markus
