Re: [PATCH bpf] bpf: offload: unlock on error in bpf_offload_dev_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>
Subject: Re: [PATCH bpf] bpf: offload: unlock on error in bpf_offload_dev_create()
From: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Date: Thu, 7 Nov 2019 00:23:18 +0100
Cc: Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20191104091536.GB31509@mwanda>
References: <20191104091536.GB31509@mwanda>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 11/4/19 10:15 AM, Dan Carpenter wrote:

We need to drop the bpf_devs_lock on error before returning.

Fixes: 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


Applied, thanks!

References:
- [PATCH bpf] bpf: offload: unlock on error in bpf_offload_dev_create()
  - From: Dan Carpenter

Prev by Date: Re: s390/pkey: Use memdup_user() rather than duplicating its implementation
Next by Date: [PATCH] ovl: create UUIDs for file systems that do not set the superblock UUID
Previous by thread: Re: [PATCH bpf] bpf: offload: unlock on error in bpf_offload_dev_create()
Next by thread: Re: [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux