> On 25/09/2019 20:49, Ira Weiny wrote: > >>> > >>> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > >>> --- > >>> drivers/nvdimm/namespace_devs.c | 19 +++++++++---------- > >>> 1 file changed, 9 insertions(+), 10 deletions(-) > >> > >> One minor nit below, but otherwise it looks good to me: > >> Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx> > > Another minor nit, the Subject says: > "bnvdimm/namsepace: Don't set claim_class on error" > > a.k.a missing the 'li' part of libnvdimm Yea... I was just rushing. V3 has this fix. Thanks, Ira > > -- > Johannes Thumshirn SUSE Labs Filesystems > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5 > 90409 Nürnberg > Germany > (HRB 247165, AG München) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850