>> Simplify this function implementation by using a known wrapper function. … > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Does this feedback indicate also an agreement for the detail if the mapping of internal phy registers would be a required operation? (Would such a resource allocation eventually be optional?) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/phy/mdio-mscc-miim.c?id=f41def397161053eb0d3ed6861ef65985efbf293#n145 https://elixir.bootlin.com/linux/v5.3.1/source/drivers/net/phy/mdio-mscc-miim.c#L145 Regards, Markus