> >
> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> > ---
> > drivers/nvdimm/namespace_devs.c | 19 +++++++++----------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
>
> One minor nit below, but otherwise it looks good to me:
> Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Thanks...
>
> >
> > diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> > index 5b22cecefc99..a020c166e1e7 100644
> > --- a/drivers/nvdimm/namespace_devs.c
> > +++ b/drivers/nvdimm/namespace_devs.c
> > @@ -1510,16 +1510,19 @@ static ssize_t holder_show(struct device *dev,
> > }
> > static DEVICE_ATTR_RO(holder);
> >
> > -static ssize_t __holder_class_store(struct device *dev, const char *buf)
> > +static int __holder_class_store(struct device *dev, const char *buf)
> > {
> > struct nd_namespace_common *ndns = to_ndns(dev);
> >
> > if (dev->driver || ndns->claim)
> > return -EBUSY;
> >
> > - if (sysfs_streq(buf, "btt"))
> > - ndns->claim_class = btt_claim_class(dev);
> > - else if (sysfs_streq(buf, "pfn"))
> > + if (sysfs_streq(buf, "btt")) {
> > + int rc = btt_claim_class(dev);
>
> Need a blank line here separating variable declarations and code.
<sigh> yea I know better... ;-)
V2 sent...
Thanks,
Ira
