Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-11-27 at 10:35 -0700, Logan Gunthorpe wrote:
> 
> On 27/11/17 10:28 AM, Joe Perches wrote:
> > It doesn't miss any mark.  It simply informs.
> > Correctness when fixing are a different world of problems.
> 
> So how come the double standard?

No double stardard.  One correctly informs that a bare
printk is not acceptable.

>  Having a missing new line warning 
> simply informs here too.

No it has a high false positive rate and newbies
act on that by submitting bad patches.'

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux