On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 11:11 PM, Julia Lawall wrote: > > I don't have a different warning if the string ends in a space. I have a > > different warning when one possible control-flow path is fine and another > > control-flow path is not. The space thing relates to guessing whether > > some other printing API function needs a newline or not. > > Understood. For checkpatch, there only is warnings (of various types) > and I was referring to the guessing you mentioned. So if we see that a > call has no new line and the following one isn't a KERN_CONT, then based > on whether there's a space or not we potentially could have one of two > warnings: > > WARNING: Log messages should end in a new line (\n) > > or > > WARNING: Given that your log message ends in a space and not a new line, > did you maybe mean to put a KERN_CONT or pr_cont somewhere in there?? By > the way, though, KERN_CONT use is discouraged and will create its own > warning when you fix it. It would probably be better not to mention the KERN_CONT possibility at all. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
