On Sun, 2016-09-25 at 09:15 +0200, SF Markus Elfring wrote: > 1. Add a definition for the macros "MY_LOG_PREFIX" and "pr_fmt" so that > their information can be used for consistent message output. > > > 2. Prefer usage of the macro "pr_info" over the interface "printk" > in this function. > > > 3. Reduce number of output function calls. > > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > > > v2: Yesterday a software development discussion pointed weaknesses out around > the previous update steps "3" and "4". > Now I propose this update variant in the hope that my second approach > for this software module will work as desired and can be accepted > a bit easier. No thank you. This is not a good change as it messes with dmesg timestamps. Simpler to read and more straightforward is multiple individual function calls. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
