On Sat, 2016-09-24 at 18:32 +0200, SF Markus Elfring wrote:
> > > @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
> > > unsigned long flags;
> > > unsigned char u;
> >
> >
> > > - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
> > > - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
> > > - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
> > > + pr_info(",------------------ START ----------------.\n"
> > > + "| Dumping: %30s |\n"
> > > + "| Speed: %28d kHz |\n",
> > > + gameport->phys,
> > > + gameport->speed);
>
>
> > Not the same output.
>
>
> Should the desired output be the same when the relevant data are passed by a single function call
> (instead of three as before)?
Adding a singleton for a pr_fmt #define constant string and
updating the printk subsystem to prepend that constant string
to each use of a pr_<level> at runtime would be an improvement
as it could reduce constant data used by the format strings.
That would be a _real_ improvement.
Please try to implement something like that before submitting
more of these incorrect patches.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
