On Sat, Apr 4, 2015 at 4:59 PM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > Put NULL test on the result of the previous call instead on one of its > arguments. A simplified version of the semantic match that finds this > problem is as follows (http://coccinelle.lip6.fr/): > > // <smpl> > r@ > expression *e1; > expression *e2; > identifier f; > statement S1,S2; > @@ > > e1 = f(...,e2,...); > ( > if (e1 == NULL || ...) S1 else S2 > | > *if (e2 == NULL || ...) S1 else S2 > ) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Yep that's a bug: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
