On 04/04/15 07:59, Julia Lawall wrote: > Put NULL test on the result of the previous call instead on one of its > arguments. A simplified version of the semantic match that finds this > problem is as follows (http://coccinelle.lip6.fr/): > > // <smpl> > r@ > expression *e1; > expression *e2; > identifier f; > statement S1,S2; > @@ > > e1 = f(...,e2,...); > ( > if (e1 == NULL || ...) S1 else S2 > | > *if (e2 == NULL || ...) S1 else S2 > ) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- Looks right. Linus? > drivers/clk/versatile/clk-versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c > index a76981e..7a4f863 100644 > --- a/drivers/clk/versatile/clk-versatile.c > +++ b/drivers/clk/versatile/clk-versatile.c > @@ -69,7 +69,7 @@ static void __init cm_osc_setup(struct device_node *np, > struct device_node *parent; > > parent = of_get_parent(np); > - if (!np) { > + if (!parent) { > pr_err("no parent on core module clock\n"); > return; > } > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
