From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Sat, 31 Jan 2015 17:34:54 +0100 > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Sat, 31 Jan 2015 17:18:48 +0100 > > The meta_delete() function could be called in four cases by the > em_meta_change() function during error handling even if the passed > variable "meta" contained still a null pointer. > > * This implementation detail could be improved by adjustments for jump labels. > > * Let us return immediately after the first failed function call according to > the current Linux coding style convention. > > * Let us delete also unnecessary checks for the variables "err" and > "meta" there. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> I kind of like the way the code is now, branching to the end of the function even when cleanups are not necessary. Inter-function return statements make code harder to audit, for locking errors, resource leaks, etc. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
