On 31.01.2015 22:52, SF Markus Elfring wrote: >>> -errout: >>> - if (err && meta) >>> - meta_delete(meta); >> >> Since this patch seems to be about optimization and cleanup you should >> probably also remove the now unnecessary initialization of "meta" with >> NULL at the beginning of the function... > > Will the optimiser of the C compiler drop any remaining unnecessary > variable initialisations? > I dont know if that matters, since the code is not only used by compilers but also read by humans. > Do you want another update step here? > I am not the one who decides if this patch is acceptable or not. But I vote for a removal of that assignment (as a part of the same patch). Regards, Lino -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
