>> The meta_delete() function could be called in four cases by the >> em_meta_change() function during error handling even if the passed >> variable "meta" contained still a null pointer. >> >> * This implementation detail could be improved by adjustments for jump labels. >> >> * Let us return immediately after the first failed function call according to >> the current Linux coding style convention. >> >> * Let us delete also unnecessary checks for the variables "err" and >> "meta" there. > > I kind of like the way the code is now, branching to the end of the function > even when cleanups are not necessary. I would appreciate if the affected exception handling can become also a bit more efficient. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
