On Wed, Nov 13, 2013 at 08:51:04AM -0500, J. Bruce Fields wrote: > On Wed, Nov 13, 2013 at 10:56:27AM +0300, Dan Carpenter wrote: > > We should unlock here before returning. > > A buggy-caller case, so shouldn't be a huge deal, but obviously should > be fixed, thanks! > > Acked-by: J. Bruce Fields <bfields@xxxxxxxxxx> > > I'm assuming Al will pick it up. > > (Though error = -EAGAIN and "goto out" would be more consistent with > other exits.) -EINVAL, but yeah you're right. I'll resend. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html