Re: [patch] locks: missing unlock on error in generic_add_lease()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2013 at 10:56:27AM +0300, Dan Carpenter wrote:
> We should unlock here before returning.

A buggy-caller case, so shouldn't be a huge deal, but obviously should
be fixed, thanks!

	Acked-by: J. Bruce Fields <bfields@xxxxxxxxxx>

I'm assuming Al will pick it up.

(Though error = -EAGAIN and "goto out" would be more consistent with
other exits.)

--b.

> 
> Fixes: df4e8d2c1d2b ('locks: implement delegations')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Static checker stuff.
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index f99d52b..92a0f0a 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -1494,6 +1494,7 @@ static int generic_add_lease(struct file *filp, long arg, struct file_lock **flp
>  
>  	if (is_deleg && arg == F_WRLCK) {
>  		/* Write delegations are not currently supported: */
> +		mutex_unlock(&inode->i_mutex);
>  		WARN_ON_ONCE(1);
>  		return -EINVAL;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux