Hello, Sorry for not responding earlier, I was away from my computer. Thanks for the review, I will send a second version that applies on top of Andy's patch and fix that typo in the change log. Best regards, Emil On Mon, Jun 10, 2013 at 12:15:22AM +0300, Andy Shevchenko wrote: > On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote: > >> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > >> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: > > >> >> What about another patch (that I guess should go first) that converts > >> >> printk to dev_* or pr_*? > >> > >> > Huh, what? Those are two totally unrelated things. Emil's patch is > >> > a bug fix. > >> > >> To be precise his patch is bugfix and cleanup at once. > >> My proposal is to add a clean up patch. > > > > The printk idea isn't a bad one, it's just totally unrelated to what > > the patch is doing. > > I don't agree with word 'totally'. It touches probe function and > shuffles code there. > > > You can't just randomly tell people to do a > > bunch of work for no reason. "Good bugfix, but before we apply it > > you have to mow my lawn." > > In this particular case I didn't think it's a big deal to fix 3 printfs. > Anyway, see patch in the next message. > > > -- > With Best Regards, > Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
