On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: > On Sun, Jun 9, 2013 at 12:08 PM, Emil Goode <emilgoode@xxxxxxxxx> wrote: > > This patch fixes some issues in the error handling and simplifies > > the code by converting to devm* functions. > > > > If the kzalloc call fails it is unnecessary to use the label no_res > > and pass a NULL pointer to kfree. If the devm_kzalloc call fails on > > line 110 we forgett to call iounmap for the previous ioremap call. > > "forget" (typo here) > > > The following changes are introduced: > > - Convert to devm_kzalloc and remove calls to kfree. > > - Convert to devm_ioremap_resource that adds a missing call to > > *request_mem_region and remove calls to iounmap. > > - The devm_ioremap_resource function checks the passed resource so > > we can remove the NULL check after the platform_get_resource call. > > What about another patch (that I guess should go first) that converts > printk to dev_* or pr_*? > Huh, what? Those are two totally unrelated things. Emil's patch is a bug fix. Patches are applied in first come first serve order anyway, so I'm not sure what you are saying. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
