> Seems to me that (assuming kfree(NULL) is ok) the kfree() > is best left in - just in case some other error path is > added after drv->cs is assigned. > Better safe than a memory leak. I'm not sure if I got your point. Now the label "error:" is only reached if drv->cs is NULL. There is not other way to move to error: unless drv->cs is NULL. Why wouldn't be safe to remove the kfree(drv->cs) when drv->cs is NULL? -- Peter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
