> Remove useless kfree() and clean up code related to the removal. ... > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c > index aa41485..30a6b17 100644 > --- a/drivers/isdn/gigaset/common.c > +++ b/drivers/isdn/gigaset/common.c > @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, > return drv; > > error: > - kfree(drv->cs); > kfree(drv); > return NULL; > } > Seems to me that (assuming kfree(NULL) is ok) the kfree() is best left in - just in case some other error path is added after drv->cs is assigned. Better safe than a memory leak. David -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
