On Tue, Sep 04, 2012 at 10:31:05AM -0700, Dan Carpenter wrote: > On Sun, Aug 19, 2012 at 07:20:54PM +0300, Tomas Winkler wrote: > > "addr" is a pointer so it's either 4 or 8 bytes, but actually we want > > to compare 6 bytes (ETH_ALEN). > > > > As network stack already provides helper function > > is_zero_ether_addr() we use that instead of memcmp > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Cc: Rupesh Gujare <rgujare@xxxxxxxxxxxxxxx> > > --- > > Generally I would frown on patch thievery but since the maintainer > asked you to then it's fine. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Oops. Doesn't compile. I see you sent a v3 already. regards, dan carpenter > > regards, > dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
