On 8/19/12, Rupesh Gujare <rgujare@xxxxxxxxxxxxxxx> wrote: > On 19/08/12 13:37, Tomas Winkler wrote: >>> On 18/08/12 09:47, Dan Carpenter wrote: >>>> "addr" is a pointer so it's either 4 or 8 bytes, but actually we want >>>> to compare 6 bytes (ETH_ALEN). >>>> >>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >>> >>> Acked-by: Rupesh Gujare<rgujare@xxxxxxxxxxxxxxx> >> why not to use 'if (is_zero_ether_addr())" from linux/etherdevice.h >> > Tom, > > Thanks for pointing this out, that looks more efficient. Interested in > submitting a patch ? > > Dan, > > What do you think ? > Yes yes. Of course. It's the weekend and I'm traveling but I can redo this. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
