Re: [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/08/12 13:37, Tomas Winkler wrote:
On 18/08/12 09:47, Dan Carpenter wrote:
"addr" is a pointer so it's either 4 or 8 bytes, but actually we want
to compare 6 bytes (ETH_ALEN).

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Rupesh Gujare<rgujare@xxxxxxxxxxxxxxx>
why not to use 'if (is_zero_ether_addr())" from linux/etherdevice.h

Tom,

Thanks for pointing this out, that looks more efficient. Interested in submitting a patch ?

Dan,

What do you think ?


--
Regards,
Rupesh Gujare




--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux