On 01/07/2011 02:51 PM, Dan Carpenter wrote: > On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote: >> Nack. You're changing an interface to userspace. Please add a check to >> av7110_ca.c instead. >> > > Ok. I've done that and resent the patch. Thanks. I'm OK with the patch, but I'll leave it to the maintainer of av7110 to decide whether he likes the cast or prefers an additional signed compare. I added him to CC. > But just for my own understanding, why is it wrong to change an int to > an unsigned int in the userspace API? Who would notice? (I'm still > quite a newbie at system programming). It would generate compiler warnings in userspace for programs checking for values < 0 or assigning negative values (for whatever reason). Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
