On 01/06/2011 08:41 PM, Dan Carpenter wrote: > In the CA_GET_SLOT_INFO ioctl, we only check whether "num" is too large, > but we don't check if it's negative. > > drivers/media/dvb/ttpci/av7110_ca.c > 278 ca_slot_info_t *info=(ca_slot_info_t *)parg; > 279 > 280 if (info->num > 1) > 281 return -EINVAL; > 282 av7110->ci_slot[info->num].num = info->num; > > Let's just make it unsigned. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Nack. You're changing an interface to userspace. Please add a check to av7110_ca.c instead. Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
