On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote: > Nack. You're changing an interface to userspace. Please add a check to > av7110_ca.c instead. > Ok. I've done that and resent the patch. But just for my own understanding, why is it wrong to change an int to an unsigned int in the userspace API? Who would notice? (I'm still quite a newbie at system programming). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html