Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 8, 2010 at 6:46 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote:
>> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@xxxxxxxxx> wrote:
>> > I patch against the next-20101006 tree.
>> >
>> > The patch series replace use of <module>-objs with <module>-y in the
>> > staging directory.
>>
>> Commit messages are written in the present tense. You happen to be
>> using two different tenses within the commit message, which is truly
>> odd.  And why did you not split apart those atrocious statements with
>> the infinite column width?
>
> As Dan said, we understand what is happening here, and we do not have
> grammer police for changelog comments, thank goodness.
>
>> This patch series adds little benefit.  As Sam has suggested, a more
>> general cleanup would be a better goal, and staging is an area that
>> needs extra attention some of which has already been pointed out in
>> other emails.
>
> But these patches are all good to have, so I will be applying them,
> please don't think they are unwanted at all.
>

This is good to know. I wonder how well received these changes will be
in other parts of the kernel though. I purposefully started in a
subsystem you maintain since I figured any criticism from you would be
constructive and you wouldn't just knack without reason.

Thanks,
mfm


-- 
GPG-Key: 9AFE00EA
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux