On Fri, Oct 8, 2010 at 1:55 AM, Dan Carpenter <error27@xxxxxxxxx> wrote: > On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote: >> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@xxxxxxxxx> wrote: >> > I patch against the next-20101006 tree. >> > >> > The patch series replace use of <module>-objs with <module>-y in the >> > staging directory. >> >> Commit messages are written in the present tense. You happen to be >> using two different tenses within the commit message, which is truly >> odd. > > Maybe *you* write in the present tense. Commit messages are important, This is not my convention; I also wrote my first few patches in the past tense but noticed they were changed to the present. > yes, but this in the end we all understood the message fine. Please > don't be a jerk. Rereading what I wrote, I realize it can be interpreted as being rude, but I think that is due to my direct writing style. My tone while writing it was very lighthearted although without knowing me I completely understand how it could come off wrong. To clarify, I thought it was odd because the two lines (subject and body) basically said the same thing using different verb tenses; my aim was not to pick apart the grammar. Thanks, mfm -- GPG-Key: 9AFE00EA -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
