On Thu, 2010-07-15 at 21:29 -0700, Greg KH wrote: > On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote: > > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > > willing to take any of these patches, sorry. > > grepping for pci device ids using constants and > > expecting the result to be comprehensive isn't > > sensible. > But it's a nice goal :) I think your goal is not a good one. For instance: $ grep -rP --include=*.[ch] "\bPCI_VDEVICE\s*\(\s*INTEL" drivers | wc -l 201 $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(PCI_VENDOR_ID_INTEL" drivers | wc -l 45 $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(\s*0x8086" drivers | wc -l 38 I'd much rather do a search for "PCI_VDEVICE.*INTEL" -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
