On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote: > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > willing to take any of these patches, sorry. > > grepping for pci device ids using constants and > expecting the result to be comprehensive isn't > sensible. But it's a nice goal :) > $ grep -rwP --include=*.[ch] -w PCI_VDEVICE drivers/char | wc -l > 32 drivers/char is not exactly a large collection of PCI drivers, only some old serial port ones. > The current drivers/ use of PCI_VDEVICE to PCI_DEVICE is ~50/50 > > $ grep --include=*.[ch] -rwP PCI_DEVICE drivers | wc -l > 866 > $ grep --include=*.[ch] -rwP PCI_VDEVICE drivers | wc -l > 768 Hey, anything to increase that ratio is good :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
