On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > willing to take any of these patches, sorry. grepping for pci device ids using constants and expecting the result to be comprehensive isn't sensible. $ grep -rwP --include=*.[ch] -w PCI_VDEVICE drivers/char | wc -l 32 The current drivers/ use of PCI_VDEVICE to PCI_DEVICE is ~50/50 $ grep --include=*.[ch] -rwP PCI_DEVICE drivers | wc -l 866 $ grep --include=*.[ch] -rwP PCI_VDEVICE drivers | wc -l 768 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html