On Sun, Jan 18, 2009 at 5:11 PM, Julia Lawall <julia@xxxxxxx> wrote: > I don't know anything about this specific context, but aren't things in > general exported so that external modules can use them? If that is the > case, grepping over the kernel sources is not sufficient. Good point, but it indicates that the function does not have a caller within kernel tree. Ok, there could be other clients. So this patch might just be a hint for the original author or maintainer that there is maybe no need to export this function. On Sun, Jan 18, 2009 at 5:18 PM, Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote: > If it is EXPORTED you cannot make it static. EXPORTED means it can be > used from a kernel module. Right, that's why I have made it static and removed the EXPORT_SYMBOL, all under the assumption that there is _no_ client for this function, but there may be some outside the kernel tree. I can not judge this. Hannes -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
